Re: [PATCH 1/5] staging: csr: sme_blocking.c: clean up tab mess

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 16, 2012 at 11:14:36PM -0700, Sungju Huh wrote:
> From: root <root@ubuntu.(none)>

This line is bogus.  We don't need this from line because we use
your email address.  Also don't work as root.

> 
> This patch converts spaces to tabs.
> 
> Signed-off-by: Sungju Huh <sjhuh@xxxxxxxxxxxxxxxxx>

Except this isn't the email address that you used to send the email
from.

The From line is for if you are sending patches on behalf of another
person (who is not just you with a using email).  Both people would
need to add a signed off by line.

regards,
dan carpenter


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux