On Wed, Oct 17, 2012 at 03:28:18PM -0400, devendra.aaru wrote: > Hi all, > > unifi_trace function is used as a debug call, do we really need it? > can we remove it if not needed? and use pr_debug, dev_dbg instead of > it at places if its needed? No, you can't just replace it automatically, otherwise lots of messages will start to get printed that weren't. But I agree, it's just debugging, where it is being used can probably all be removed, but for now, I'd leave it alone, there are bigger things to clean up here. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel