Re: [RFC] staging: slicoss: remove assert macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 17, 2012 at 2:06 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Oct 17, 2012 at 01:57:49PM -0400, Devendra Naga wrote:
>> remove the ASSERT() macro and all of its calls altogether,
>>
>> there is a minor problem, that i fixed too in this patch.
>>
>> the problem is we try to request_firmware a file name "",
>> which fail eventually, instead we should fail at the default
>> case returning -ENOENT.
>
> Please break this up in two patches, one fixing this, and the other one
> removing the ASSERT() macro.  That way the bugfix can be backported to
> other kernel releases if needed.
>
Sure sir, i will do in next interation and will wait for some more
comments for others, :)
and implement the changes as you / others suggested.

> greg k-h

Thanks
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux