On Fri, Oct 12, 2012 at 12:01 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Thu, Oct 11, 2012 at 09:02:04PM -0400, Kevin McKinney wrote: >> @@ -193,7 +193,7 @@ VOID Bcm_kill_all_URBs(PS_INTERFACE_ADAPTER psIntfAdapter) >> */ >> >> /* Cancel submitted Interrupt-URB's */ >> - if (psIntfAdapter->psInterruptUrb != NULL) { >> + if (!psIntfAdapter->psInterruptUrb) { > > This test is reversed. Btw, if you run Smatch on your code it would > have caught this. > Yeah, this is a stupid mistake on my part. I usually verify with Smatch before submitting, I just did not last night; but I will from now on. I will resubmit this entire patch set. Thanks, Kevin _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel