> -----Original Message----- > From: Rusty Russell [mailto:rusty@xxxxxxxxxx] > Sent: Monday, October 08, 2012 1:46 AM > To: KY Srinivasan; gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx; > akpm@xxxxxxxxxxxxxxxxxxxx; andi@xxxxxxxxxxxxxx > Cc: KY Srinivasan > Subject: Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver > > "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx> writes: > > +static int hot_add; > > + > > +module_param(hot_add, int, S_IRUGO); > > +MODULE_PARM_DESC(hot_add, "If set attempt memory hot_add"); > > I think this should be a 'bool', but I can't tell, since it's not used > in this patch. You are right; currently, I unconditionally fail the hot add request. Hopefully, I will soon be able to support hot add once I get the needed host side changes. Regards, K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel