RE: [PATCH RESEND] staging: comedi: ni_daq_700: fix dio subdevice regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, October 02, 2012 3:10 AM, Ian Abbott wrote:
> From: Fred Brooks <nsaspook@xxxxxxxxxxxx>
>
> Here is a small patch to fix a problem caused by a previous patch that
> removed the  callback function.  The callback remove patch:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=1de02225358988e8fd48d1dc3fd12336bbae258a
>
> I finally booted my dev machine on the latest kernel (running Debian
> here so it's still on 3.2 normally) to test the ni_daq_700 driver with
> my test program and noticed this bug.
>
> Shift the DIO_R read result to bits 8..15 Digital direction
> configuration: channels 0-7 output, 8-15 input (8225 device emu as port
> A output, port B input, port C N/A).
>
> Cc: <stable@xxxxxxxxxxxxxxx> # 3.6.x
> Signed-off-by: Fred Brooks <nsaspook@xxxxxxxxxxxx>
> Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx>

Ian,

The DIO is not really configurable on this board. I wonder if it
would be cleaner to split it into two subdevices, a DI and a DO
subdevice. This would allow getting rid of the insn_config
function and might better represent the actual hardware.

Regards,
Hartley

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux