Re: [PATCH 2/3] Add parenthesis to macros with complex values in trace.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2012-10-02 at 20:54 +0900, YAMANE Toshiaki wrote: 
> fixed some checkpatch below error.
> -ERROR: Macros with complex values should be enclosed in parenthesis
> 
> Signed-off-by: Toshiaki Yamane <yamanetoshi@xxxxxxxxx>
> ---
>  drivers/staging/rts_pstor/trace.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rts_pstor/trace.h b/drivers/staging/rts_pstor/trace.h
> index 740999c..a34493c 100644
> --- a/drivers/staging/rts_pstor/trace.h
> +++ b/drivers/staging/rts_pstor/trace.h
> @@ -78,8 +78,8 @@ do {													\
>  	goto label; 											\
>  } while (0)
>  #else
> -#define TRACE_RET(chip, ret)	return ret
> -#define TRACE_GOTO(chip, label)	goto label
> +#define TRACE_RET(chip, ret)	return(ret)
> +#define TRACE_GOTO(chip, label)	goto(label)
>  #endif
In this specific case I think checkpatch.pl wants more than needed.


-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux