Hi Joerg, On Thu, 2012-09-27 at 12:20 +0200, Joerg Roedel wrote: > Hi Shuah, > > the patch looks better then the older versions. It comes closer to a > merge, but I see one issue here: > > On Tue, Sep 25, 2012 at 07:05:17PM -0600, Shuah Khan wrote: > > debug_dma_mapping_error(struct device *dev, dma_addr_t dma_addr): > > Sets dma map error checked status for the dma map entry if one is > > found. Decrements the system wide dma_map_errors_not_checked counter > > that is incremented by debug_dma_map_page() when it checks for > > mapping error before adding it to the dma debug entry table. > > It is problematic that the DMA debug code can no longer call > dma_mapping_error because of this. How about adding a special version of > that function which does no checking and use it in the DMA debug code > instead? Yes. Konrad expressed the same concern and I understand the reasons. Defining a special version of dma_mapping_error() will eliminate the problem that prevents this routine being used from dma-debug api. Will do that. Working on a v3 patch to fix this problem as well as the other review comments from Konrad. Hoping I can have it ready in by the end of this week(end) Thanks, -- Shuah _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
