On Wed, Sep 26, 2012 at 10:48:15PM +0200, Daniel Walter wrote:
> [staging] ft1000: replace strict_strtoul with kstrtou8
Remove this line.
Don't send patches on the same day that you write them.
>
> * replace deprecated strict_strtoul with newer kstrtou8
>
> Signed-off-by: Daniel Walter <sahne@xxxxxxx>
> ---
> apply against current linux-next tree
>
> changed from kstrtoul to kstrtou8 as dan recommended
>
> ---
> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
> index 809fa48..792ac77 100644
> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
> @@ -723,7 +723,7 @@ int init_ft1000_netdev(struct ft1000_device *ft1000dev)
> if (strncmp(netdev->name, "eth", 3) == 0) {
> card_nr[0] = netdev->name[3];
> card_nr[1] = '\0';
> - ret_val = strict_strtoul(card_nr, 10, &gCardIndex);
> + ret_val = kstrtou8(card_nr, 10, &gCardIndex);
This is not correct either. You didn't try compiling this crap.
SLOW DOWN. CLAM YOUR PANTS! There is not rush because no patches
are going to be accepted for the next 3 weeks.
gCardIndex needs to be declared as a u8.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
