Re: [PATCH] staging: line6: replace strict_strto* with kstrto*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 26, 2012 at 09:59:34PM +0200, Daniel Walter wrote:
> [staging] line6: replace strict_strtoul/strict_strtol with kstrtoul/kstrtol
> 
>  * replace deprecated string conversions with kstrtol/kstrtoul
> 
> Signed-off-by: Daniel Walter <sahne@xxxxxxx>;
> 

Redo against linux-next.

> ---
>  drivers/staging/line6/toneport.c |    4 ++--
>  drivers/staging/line6/variax.c   |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> ---
> diff --git a/drivers/staging/line6/toneport.c b/drivers/staging/line6/toneport.c
> index 31b624b..0828480 100644
> --- a/drivers/staging/line6/toneport.c
> +++ b/drivers/staging/line6/toneport.c
> @@ -129,7 +129,7 @@ static ssize_t toneport_set_led_red(struct device *dev,
>  	int retval;
>  	long value;
>  
> -	retval = strict_strtol(buf, 10, &value);
> +	retval = kstrtol(buf, 10, &value);
>  	if (retval)
>  		return retval;
>  

Should probably by kstrtoint() to match led_red.  Except that
led_red really should be unsigned and I don't know why it isn't.

(In the strict_strtol() we didn't have "int" versions of the
function).

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux