On Wed, Sep 26, 2012 at 09:58:57PM +0200, Daniel Walter wrote:
> [staging] easycap: replace strict_strtol with kstrtol
>
> * replace deprecated string conversion
>
> Signed-off-by: Daniel Walter <sahne@xxxxxxx>
> ---
> apply against current linux-2.6 tree
It has to be redone against linux-next.
Use get_maintainer.pl to send this to the correct list.
This driver has been replaced anyway.
> ---
> drivers/staging/media/easycap/easycap_ioctl.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> ---
> diff --git a/drivers/staging/media/easycap/easycap_ioctl.c b/drivers/staging/media/easycap/easycap_ioctl.c
> index 3cee3cd..539c360 100644
> --- a/drivers/staging/media/easycap/easycap_ioctl.c
> +++ b/drivers/staging/media/easycap/easycap_ioctl.c
> @@ -1033,9 +1033,9 @@ long easycap_unlocked_ioctl(struct file *file,
> if (*p2)
> *p2++ = 0;
> if (3 > i) {
> - rc = (int) strict_strtol(p1, 10, &lng);
> + rc = (int) kstrtol(p1, 10, &lng);
This wouldn't be the right way to do this. This is a straight sed
type patch, but we want a more thoughtful patch. Get rid of the lng
variable. Use kstrtoint(). Get rid of the nonsense int => int cast
of the return value.
> if (rc) {
> - SAM("ERROR: %i=strict_strtol(%s,.,,)\n",
> + SAM("ERROR: %i=kstrtol(%s,.,,)\n",
Good job on updating the error message though. A lot of people
would have missed that.
Are you part of a class or something? There has been a number of
first time patch submitters in the past couple days.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
