Re: staging: Add dgrp driver for Digi Realport devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> I have a concern about the following code:
> 
> drivers/staging/dgrp/dgrp_net_ops.c:3159 dgrp_receive()
>   3128                                  plen = get_unaligned_be16(b + 2);
>   3129  
>   3130                                  if (plen < 4 || plen > 1000) {
>                                             ^^^^^^^^
> plen = 4 here.  It is a signed long.
> 

Thanks, I fear it's probably full of things like this.  I cleaned up
the stuff that I saw as obviously bad, but I figured I needed more
eyes on it.

I'll work up a fix for this.

-- 
Bill
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux