On Thu, Sep 20, 2012 at 09:44:53AM +0100, Ian Abbott wrote: > On 2012/09/19 08:02 PM, Dan Carpenter wrote: > > On Wed, Sep 19, 2012 at 07:37:35PM +0100, Ian Abbott wrote: > >> Pointers to user data within ioctl data structures should keep the > >> __user tag. > >> > > > > You can't do this until you've modified all the drivers. It just > > introduces a lot of warnings for no reason. > > You could stick patch 1 at the end if it helps. Ok, I'm totally confused now (but that's probably just the jet lag...) I've applied a bunch of different patches from Ian and Hartley, trying to stay away from the __user ones until everyone agrees on what to do here. So, can both of you resync on my tree now, and resend anything that I missed? And what's the decision on the __user cleanups? Personally, I feel Dan is right, the __user pointers should NOT be passed to the individual drivers, that work needs to be done in the core so it's done once, done right, and is easy to audit. It should not be anything that a driver needs to worry about. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel