On Fri, Sep 21, 2012 at 3:02 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Thu, Sep 20, 2012 at 10:43:45PM -0400, Kevin McKinney wrote:
>> This patch removes typedef for stLocalSFDeleteIndication,
>> changes the name of the struct to
>> bcm_stlocalsfdelind. In addition, any
>> calls to the following typedef
>> "stLocalSFDeleteIndication" are changed to call
>> the struct directly.
>
> The new name is hard to understand. I think the "st" in
> stLocalSFDeleteIndication and bcm_stlocalsfdelind stands for
> struct. We can remove that.
Yeah, I also think the "st" stands for structure. Okay I can remove this.
> Does the "local" mean there is also a "remote" version?
> SF stands for Service Flow I think. That seems fine.
> It's better to put underscores between words if you can.
> So maybe something like:
I am not sure why they had local here, I originally thought maybe
there was a corresponding structure residing in user space, but I was
not completely sure. Let me find out and I will change this based on
what I find.
> struct bcm_sf_del_ind {
>
> (I don't know. I'm just throwing that out there without having
> looked very hard at the code).
>
>> /*
>> - * structure stLocalSFDeleteIndication
>> + * structure bcm_stlocalsfdelind
>> */
>
> Just remove these comments, don't update them.
Okay, I will remove these comments, and resubmit the entire patch set
with the above changes.
Thanks,
Kevin
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
