[PATCH] staging:ced1401: remove read write callbacks from fops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



As the driver says that read and writes should not be performed
and instead the user to kernel transactions are performed through
ioctl interface, remove these functions as they are not required

Signed-off-by: Devendra Naga <devendra.aaru@xxxxxxxxx>
---
 drivers/staging/ced1401/usb1401.c |   20 --------------------
 1 files changed, 0 insertions(+), 20 deletions(-)

diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c
index 59d69b4..6ba0ef6 100644
--- a/drivers/staging/ced1401/usb1401.c
+++ b/drivers/staging/ced1401/usb1401.c
@@ -261,24 +261,6 @@ static int ced_flush(struct file *file, fl_owner_t id)
 	return res;
 }
 
-static ssize_t ced_read(struct file *file, char *buffer, size_t count,
-			loff_t * ppos)
-{
-	DEVICE_EXTENSION *pdx = file->private_data;
-	dev_err(&pdx->interface->dev, "%s called: use ioctl for cedusb",
-		__func__);
-	return 0;		// as we do not do reads this way
-}
-
-static ssize_t ced_write(struct file *file, const char *user_buffer,
-			 size_t count, loff_t * ppos)
-{
-	DEVICE_EXTENSION *pdx = file->private_data;
-	dev_err(&pdx->interface->dev, "%s called: use ioctl for cedusb",
-		__func__);
-	return 0;
-}
-
 /***************************************************************************
 ** CanAcceptIoRequests
 ** If the device is removed, interface is set NULL. We also clear our pointer
@@ -1402,8 +1384,6 @@ static int ced_ioctl(struct inode *node, struct file *file, unsigned int cmd,
 
 static const struct file_operations ced_fops = {
 	.owner = THIS_MODULE,
-	.read = ced_read,
-	.write = ced_write,
 	.open = ced_open,
 	.release = ced_release,
 	.flush = ced_flush,
-- 
1.7.1

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux