The comedi_aux_data() helper is used to get the firmware data and size that are passed to the comedi core using the COMEDI_DEVCONFIG ioctl with the comedi_config utility. The only users of this helper are the usbdux drivers and the me_daq PCI driver. The usbdux drivers already support getting the firmware using request_firmware_nowait(). They also support the comedi USB auto config mechanism for the attach. Simply removing the legacy attach method removes their need for comedi_aux_data(). The me_daq driver still uses the legacy attach. By changing the firmware load to use request_firmware(), the need for comedi_aux_data() is removed. Then we can also convert the driver to use the comedi PCI auto config mechanism. H Hartley Sweeten (5): staging: comedi: usbduxsigma: remove usbduxsigma_attach staging: comedi: usbduxfast: remove usbduxfast_attach staging: comedi: usbdux: remove usbdux_attach staging: comedi: me_daq: use request_firmware() staging: comedi: me_daq: use attach_pci callback drivers/staging/comedi/drivers/me_daq.c | 149 +++++++++++---------------- drivers/staging/comedi/drivers/usbdux.c | 55 +--------- drivers/staging/comedi/drivers/usbduxfast.c | 54 +--------- drivers/staging/comedi/drivers/usbduxsigma.c | 53 +--------- 4 files changed, 72 insertions(+), 239 deletions(-) -- 1.7.11 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
