On Wed, Sep 19, 2012 at 02:50:12AM -0400, Devendra Naga wrote:
> the dc_init_descriptor_list actually returns a +ve error return codes,
> which is abnormal as other functions in kernel return -ve error codes on
> failure. so replace the return codes of this function with -ve values
> to make the consistency with the other functions in kernel
>
> Signed-off-by: Devendra Naga <devendra.aaru@xxxxxxxxx>
> ---
> v2: fix the subject line
> drivers/staging/sbe-2t3e3/dc.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/sbe-2t3e3/dc.c b/drivers/staging/sbe-2t3e3/dc.c
> index 9e81d90..51079f2 100644
> --- a/drivers/staging/sbe-2t3e3/dc.c
> +++ b/drivers/staging/sbe-2t3e3/dc.c
> @@ -317,7 +317,7 @@ u32 dc_init_descriptor_list(struct channel *sc)
^^^
It's declared as a u32. Perhaps you could make it a static function
as well.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
