Introduce a `struct comedi_kcmd` to shadow the `struct comedi_cmd` used by the `COMEDI_CMD` and `COMEDI_CMDTEST` ioctls defined in "comedi.h". Change the low-level comedi drivers and the comedi core to use the new type for the kernel copy of the comedi command. Patches 48 to 50 fix some other sparse warnings in the comedi core. One of these (patch 49) is an actual bug fix correcting an invalid dereference of user-space memory. (Useful, this "sparse" thing!) I noticed various related problems in some of the low-level drivers, but I'll fix those later. drivers/staging/comedi/comedi_fops.c | 88 +++++++++++----------- drivers/staging/comedi/comedidev.h | 29 ++++++- drivers/staging/comedi/drivers.c | 1 - drivers/staging/comedi/drivers/8255.c | 2 +- .../staging/comedi/drivers/addi-data/addi_common.h | 2 +- .../comedi/drivers/addi-data/hwdrv_apci3120.c | 31 ++++---- .../comedi/drivers/addi-data/hwdrv_apci3120.h | 5 +- .../comedi/drivers/addi-data/hwdrv_apci3200.c | 37 +++++---- .../comedi/drivers/addi-data/hwdrv_apci3200.h | 5 +- drivers/staging/comedi/drivers/adl_pci9111.c | 4 +- drivers/staging/comedi/drivers/adl_pci9118.c | 4 +- drivers/staging/comedi/drivers/adv_pci1710.c | 4 +- drivers/staging/comedi/drivers/amplc_dio200.c | 6 +- drivers/staging/comedi/drivers/amplc_pc236.c | 2 +- drivers/staging/comedi/drivers/amplc_pci224.c | 10 +-- drivers/staging/comedi/drivers/amplc_pci230.c | 26 ++++--- drivers/staging/comedi/drivers/cb_das16_cs.c | 2 +- drivers/staging/comedi/drivers/cb_pcidas.c | 12 +-- drivers/staging/comedi/drivers/cb_pcidas64.c | 70 ++++++++--------- drivers/staging/comedi/drivers/cb_pcidda.c | 2 +- drivers/staging/comedi/drivers/comedi_parport.c | 2 +- drivers/staging/comedi/drivers/comedi_test.c | 6 +- drivers/staging/comedi/drivers/das16.c | 8 +- drivers/staging/comedi/drivers/das16m1.c | 6 +- drivers/staging/comedi/drivers/das1800.c | 24 +++--- drivers/staging/comedi/drivers/das800.c | 4 +- drivers/staging/comedi/drivers/dmm32at.c | 6 +- drivers/staging/comedi/drivers/dt2814.c | 5 +- drivers/staging/comedi/drivers/dt282x.c | 10 ++- drivers/staging/comedi/drivers/dt3000.c | 4 +- drivers/staging/comedi/drivers/gsc_hpdi.c | 8 +- drivers/staging/comedi/drivers/me4000.c | 14 ++-- drivers/staging/comedi/drivers/me_daq.c | 3 +- drivers/staging/comedi/drivers/ni_6527.c | 4 +- drivers/staging/comedi/drivers/ni_65xx.c | 4 +- drivers/staging/comedi/drivers/ni_660x.c | 4 +- drivers/staging/comedi/drivers/ni_at_a2150.c | 6 +- drivers/staging/comedi/drivers/ni_atmio16d.c | 4 +- drivers/staging/comedi/drivers/ni_labpc.c | 33 ++++---- drivers/staging/comedi/drivers/ni_mio_common.c | 22 +++--- drivers/staging/comedi/drivers/ni_pcidio.c | 7 +- drivers/staging/comedi/drivers/ni_tio.h | 2 +- drivers/staging/comedi/drivers/ni_tiocmd.c | 8 +- drivers/staging/comedi/drivers/pcl711.c | 5 +- drivers/staging/comedi/drivers/pcl812.c | 5 +- drivers/staging/comedi/drivers/pcl816.c | 9 ++- drivers/staging/comedi/drivers/pcl818.c | 6 +- drivers/staging/comedi/drivers/pcm_common.c | 2 +- drivers/staging/comedi/drivers/pcm_common.h | 2 +- drivers/staging/comedi/drivers/pcmmio.c | 6 +- drivers/staging/comedi/drivers/pcmuio.c | 6 +- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 4 +- drivers/staging/comedi/drivers/rtd520.c | 4 +- drivers/staging/comedi/drivers/s626.c | 10 +-- drivers/staging/comedi/drivers/skel.c | 4 +- drivers/staging/comedi/drivers/usbdux.c | 10 ++- drivers/staging/comedi/drivers/usbduxfast.c | 4 +- drivers/staging/comedi/drivers/usbduxsigma.c | 8 +- 58 files changed, 332 insertions(+), 289 deletions(-) _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel