On Fri, Sep 14, 2012 at 02:02:04PM +0800, Macpaul Lin wrote: > Replace firmware upgrade API in em_download_image(). > > Signed-off-by: Macpaul Lin <macpaul@xxxxxxxxx> > Cc: Paul Stewart <pstew@xxxxxxxxxxxx> > Cc: Ben Chan <benchan@xxxxxxxxxxxx> > Cc: Sage Ahn <syahn@xxxxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > Changes for v2: > - Correction the procedure in em_download_image() and usb_emergency() > - keep "goto out" in em_download_image because release_firmware is > required in many case during download fail. > > Changes for v3: > - Add "const" declaration for char * variables which is used for > firmware names. > > drivers/staging/gdm72xx/usb_boot.c | 77 ++++++++++++++++++-------------------- > 1 file changed, 37 insertions(+), 40 deletions(-) > > diff --git a/drivers/staging/gdm72xx/usb_boot.c b/drivers/staging/gdm72xx/usb_boot.c > index 80870a0..0787188 100644 > --- a/drivers/staging/gdm72xx/usb_boot.c > +++ b/drivers/staging/gdm72xx/usb_boot.c > @@ -32,8 +32,8 @@ > #define MAX_IMG_CNT 16 > #define FW_DIR "gdm72xx/" > #define FW_UIMG "gdmuimg.bin" > -#define KERN_PATH "/lib/firmware/gdm72xx/zImage" > -#define FS_PATH "/lib/firmware/gdm72xx/ramdisk.jffs2" > +#define FW_KERN "zImage" > +#define FW_FS "ramdisk.jffs2" For some reason, I don't think that this really is your "firmware" name, right? That looks like a kernel and a filesystem name. What is going on here with this code? Why would the kernel load a kernel? greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
