Re: [PATCH 07/24] Staging: ipack/devices/ipoctal: Store isr masks in ipoctal_channel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 13, 2012 at 08:43:12PM +0300, Dan Carpenter wrote:
> On Wed, Sep 12, 2012 at 02:55:29PM +0200, Samuel Iglesias Gonsalvez wrote:
> > From: Jens Taprogge <jens.taprogge@xxxxxxxxxxxx>
> > 
> > This way interrupt handling becomes independent of the channel number.
> > 
> > Signed-off-by: Jens Taprogge <jens.taprogge@xxxxxxxxxxxx>
> > Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@xxxxxxxxxx>
> > ---
> > @@ -213,7 +206,7 @@ static int ipoctal_irq_handler(void *arg)
> >  		}
> >  
> >  		/* RX data */
> > -		if (isr_rx_rdy && (sr & SR_RX_READY)) {
> > +		if ((isr && channel->isr_rx_rdy_mask) && (sr & SR_RX_READY)) {
>                          ^^
> Bitwise AND intended here I think.
> 

Never mind.  It gets silently fixed in the next patch.

Regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux