On Tuesday, September 11, 2012 2:06 AM, Ian Abbott wrote: > On 2012-09-11 04:12, Greg KH wrote: >> On Mon, Sep 10, 2012 at 06:49:47PM -0700, H Hartley Sweeten wrote: >>> Remove the boardinfo and convert this driver to use the comedi attach_pci >>> auto config mechanism. >>> >>> Use the 8253 helpers and remove the code for programming the timers. >>> >>> Remove a bunch of debug code and all the i/o macros. >>> >>> Introduce two new helper functions to comedi_fc. These will be used >>> to help cleanup the 'do_cmdtest' functions in the comedi drivers. >> >> I applied the first 39 patches, I'd like to get Ian's ack for patch 40 >> that adds this function before applying it, and the rest of these >> patches. >> >> Ian, any objection? > > I'd probably make it a static inline function in comedi_fc.h as the > function is very short. This also applies to the > cfc_check_trigger_is_unique function in patch 43. That would also avoid > loading in the comedi_fc module for those drivers that don't do so already. Makes sense. Greg, Making the change only effects patches 40/46 and 43/46. Since you have already applied the first 39 patches, would you like me to just repost those two or would you prefer a new series with the last 7 patches? Thanks, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
