Re: bcm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 11, 2012 at 06:33:19AM +0600, Rinat Camalov wrote:
> 
> CC the devel list ?????? What is that?

Add this to the CC list:  devel@xxxxxxxxxxxxxxxxxxxx

You're not using the upstream code?  Can you try compiling the 3.5
kernel?  It's not going to work either, but at least we'll all be
using the same source.

This driver is so full of absolute crap, but there wasn't anyone to
test it.  And we thought it didn't work at all anyway so it was
discouraging.

These warnings are still there and there is a comment that the
code can't possibly be right (on 64 bit).  So that's one place to
start.

> /home/richman/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
> /home/richman/bcm/CmHost.c:1401:39: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> /home/richman/bcm/CmHost.c:1440:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> /home/richman/bcm/CmHost.c:1454:35: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

Also the whole driver just needs cleaned up.  If someone did that
they would find a ball of things to fix.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux