On Tue, Sep 11, 2012 at 04:50:15AM +0200, Bruce Humphrey wrote:
> Change 5 instances of printk(KERN_INFO, KERN_WARN and KERN_ERROR for the prefered pr_info, pr_warn and pr_error
>
> Signed-off-by: Bruce Humphrey Ventura <brucehum@xxxxxxxxx>
> ---
> drivers/staging/comedi/drivers/fl512.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/fl512.c b/drivers/staging/comedi/drivers/fl512.c
> index d1da809..258a7b4 100644
> --- a/drivers/staging/comedi/drivers/fl512.c
> +++ b/drivers/staging/comedi/drivers/fl512.c
> @@ -118,9 +118,9 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> struct comedi_subdevice *s;
>
> iobase = it->options[0];
> - printk(KERN_INFO "comedi:%d fl512: 0x%04lx", dev->minor, iobase);
> + pr_info("comedi:%d fl512: 0x%04lx", dev->minor, iobase);
> if (!request_region(iobase, FL512_SIZE, "fl512")) {
> - printk(KERN_WARNING " I/O port conflict\n");
> + pr_warn(" I/O port conflict\n");
> return -EIO;
These weren't right at all in the original code. Doing small white
space cleanups is pointless when the print statements are wrong.
(Line continuations. Also printing bogus nonsense. Look Hartley's
patches for examples on how to fix these properly).
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
