Hi Devendra,
2012/9/6 Devendra Naga <devendra.aaru@xxxxxxxxx>:
> a) put the device_get_options functions' opening brace below
> b) replace spaces with tabs
>
> Signed-off-by: Devendra Naga <devendra.aaru@xxxxxxxxx>
> ---
> drivers/staging/vt6655/device_main.c | 48 ++++++++++++++++------------------
> 1 file changed, 23 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index e0a9c08..bb0b0cf 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -398,31 +398,29 @@ device_set_bool_opt(unsigned int *opt, int val,bool def,u32 flag, char* name,cha
> }
> }
> */
> -static void
> -device_get_options(PSDevice pDevice, int index, char* devname) {
> -
> - POPTIONS pOpts = &(pDevice->sOpts);
> - pOpts->nRxDescs0=RX_DESC_DEF0;
> - pOpts->nRxDescs1=RX_DESC_DEF1;
> - pOpts->nTxDescs[0]=TX_DESC_DEF0;
> - pOpts->nTxDescs[1]=TX_DESC_DEF1;
> -pOpts->flags|=DEVICE_FLAGS_IP_ALIGN;
> - pOpts->int_works=INT_WORKS_DEF;
> - pOpts->rts_thresh=RTS_THRESH_DEF;
> - pOpts->frag_thresh=FRAG_THRESH_DEF;
> - pOpts->data_rate=DATA_RATE_DEF;
> - pOpts->channel_num=CHANNEL_DEF;
> -
> -pOpts->flags|=DEVICE_FLAGS_PREAMBLE_TYPE;
> -pOpts->flags|=DEVICE_FLAGS_OP_MODE;
> -//pOpts->flags|=DEVICE_FLAGS_PS_MODE;
> - pOpts->short_retry=SHORT_RETRY_DEF;
> - pOpts->long_retry=LONG_RETRY_DEF;
> - pOpts->bbp_type=BBP_TYPE_DEF;
> -pOpts->flags|=DEVICE_FLAGS_80211h_MODE;
> -pOpts->flags|=DEVICE_FLAGS_DiversityANT;
> -
> -
> +static void device_get_options(PSDevice pDevice, int index, char* devname)
> +{
> + POPTIONS pOpts = &(pDevice->sOpts);
> +
> + pOpts->nRxDescs0 = RX_DESC_DEF0;
> + pOpts->nRxDescs1 = RX_DESC_DEF1;
> + pOpts->nTxDescs[0] = TX_DESC_DEF0;
> + pOpts->nTxDescs[1] = TX_DESC_DEF1;
> + pOpts->flags |= DEVICE_FLAGS_IP_ALIGN;
> + pOpts->int_works = INT_WORKS_DEF;
> + pOpts->rts_thresh = RTS_THRESH_DEF;
> + pOpts->frag_thresh = FRAG_THRESH_DEF;
> + pOpts->data_rate = DATA_RATE_DEF;
> + pOpts->channel_num = CHANNEL_DEF;
> +
> + pOpts->flags |= DEVICE_FLAGS_PREAMBLE_TYPE;
> + pOpts->flags |= DEVICE_FLAGS_OP_MODE;
> + //pOpts->flags|=DEVICE_FLAGS_PS_MODE;
Here you could remove this commented line right? But I think it copuld
be done in another patch.
Now the code could be read!
> + pOpts->short_retry = SHORT_RETRY_DEF;
> + pOpts->long_retry = LONG_RETRY_DEF;
> + pOpts->bbp_type = BBP_TYPE_DEF;
> + pOpts->flags |= DEVICE_FLAGS_80211h_MODE;
> + pOpts->flags |= DEVICE_FLAGS_DiversityANT;
> }
>
> static void
> --
> 1.7.9.5
>
Acked-by: Marcos Paulo de Souza <marcos.souza.org@xxxxxxxxx>
--
Att,
Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
