> From: Dan Magenheimer > Subject: RE: [patch] staging: ramster: fix range checks in zcache_autocreate_pool() > > > From: Greg Kroah-Hartman [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > > Subject: Re: [patch] staging: ramster: fix range checks in zcache_autocreate_pool() > > > > On Thu, Sep 06, 2012 at 03:40:20PM +0300, Dan Carpenter wrote: > > > If "pool_id" is negative then it leads to a read before the start of the > > > array. If "cli_id" is out of bounds then it leads to a NULL dereference > > > of "cli". GCC would have warned about that bug except that we > > > initialized the warning message away. > > > > > > Also it's better to put the parameter names into the function > > > declaration in the .h file. It serves as a kind of documentation. > > > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > --- > > > BTW, This file has a ton of GCC warnings. This function returns -1 > > > on error which is a nonsense return code but the return value is not > > > checked anyway. *Grumble*. > > > > I agree, it's very messy. Dan Magenheimer should have known better, and > > he better be sending me a patch soon to remove these warnings (hint...) > > On its way soon. > > > BTW, This file has a ton of GCC warnings. Submitted (with typo in kernel-janitors address)... but I also just realized from previous feedback on a much earlier thread... I use a stable RHEL6-ish system for devel/test with gcc-4.4.5, and newer gcc's may report more warnings than I see or have fixed. If there is now a required newer gcc version for patch submittals, please let me know. (However, I will be away from email for a few days, so apologies in advance if I can't respond immediately.) _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
