Hello Jens Taprogge,
The patch 4aa09d47d45e: "Staging: ipack: Implement device matching on
the bus level." from Sep 4, 2012, leads to the following warning:
drivers/staging/ipack/ipack.c:34 ipack_match_one_device()
error: id->format is never equal to -1 (wrong type 0 - 255).
30 static inline const struct ipack_device_id *
31 ipack_match_one_device(const struct ipack_device_id *id,
32 const struct ipack_device *device)
33 {
34 if ((id->format == IPACK_ANY_ID || id->format == device->id_format) &&
35 (id->vendor == IPACK_ANY_ID || id->vendor == device->id_vendor) &&
36 (id->device == IPACK_ANY_ID || id->device == device->id_device))
37 return id;
38 return NULL;
39 }
IPACK_ANY_ID is defined as:
define IPACK_ANY_ID (~0)
id->format is a u8 so the comparison is never true. ->vendor and
->device are u32 so those work because IPACK_ANY_ID is casted to u32
for the comparison.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
