> -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Tuesday, September 04, 2012 6:59 PM > To: KY Srinivasan > Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; > apw@xxxxxxxxxxxxx; ben@xxxxxxxxxxxxxxx; thozza@xxxxxxxxxx; > dcbw@xxxxxxxxxx > Subject: Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve dhcp > state > > On Tue, Sep 04, 2012 at 02:46:37PM -0700, K. Y. Srinivasan wrote: > > To keep the KVP daemon code free of distro specific details, we invoke an > > external script to retrieve the DHCP state. This is an example script that > > was used to test the KVP code. This script has to be implemented in a Distro > > specific fashion. For instance on distros that ship with Network Manager > enabled, > > this script can be based on NM APIs. > > > > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > > Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > > --- > > tools/hv/hv_get_dhcp_info.sh | 25 +++++++++++++++++++++++++ > > 1 files changed, 25 insertions(+), 0 deletions(-) > > create mode 100755 tools/hv/hv_get_dhcp_info.sh > > > > diff --git a/tools/hv/hv_get_dhcp_info.sh b/tools/hv/hv_get_dhcp_info.sh > > new file mode 100755 > > index 0000000..3de4587 > > --- /dev/null > > +++ b/tools/hv/hv_get_dhcp_info.sh > > @@ -0,0 +1,25 @@ > > +#!/bin/bash > > + > > +# This example script retrieves the DHCP state of a given interface. > > +# In the interest of keeping the KVP daemon code free of distro specific > > +# information; the kvp daemon code invokes this external script to gather > > +# DHCP setting for the specific interface. > > +# > > +# Input: Name of the interface > > +# > > +# Output: The script prints the string "Enabled" to stdout to indicate > > +# that DHCP is enabled on the interface. > > What happens if DHCP is not enabled on the interface? Shouldn't that > also return something other than "success"? The script is expected to write "Enabled" to stdout to indicate if DHCP is enabled; if this is not the case, implicitly we assume DHCP is not enabled (since this is a binary state). Regards, K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
