2012/9/4 Devendra Naga <devendra.aaru@xxxxxxxxx>:
> the kzalloc does allocates memory and sets the data at the memory
> which is allocated to 0,
>
> The driver does uses the kmalloc and memset at some points in the code
> replace them with a single call to kzalloc
>
> Signed-off-by: Devendra Naga <devendra.aaru@xxxxxxxxx>
> ---
> drivers/staging/csr/sme_sys.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/csr/sme_sys.c b/drivers/staging/csr/sme_sys.c
> index b9b51c6..758c276 100644
> --- a/drivers/staging/csr/sme_sys.c
> +++ b/drivers/staging/csr/sme_sys.c
> @@ -2815,12 +2815,11 @@ u8 blockack_session_start(unifi_priv_t *priv,
> }
>
> /* create and populate the new BA session structure */
> - ba_session_tx = kmalloc(sizeof(ba_session_tx_struct), GFP_KERNEL);
> + ba_session_tx = kzalloc(sizeof(ba_session_tx_struct), GFP_KERNEL);
> if (!ba_session_tx) {
> unifi_error(priv, "%s: kmalloc failed for ba_session_tx\n", __FUNCTION__);
> return FALSE;
> }
> - memset(ba_session_tx, 0, sizeof(ba_session_tx_struct));
>
> ba_session_tx->interfacePriv = interfacePriv;
> ba_session_tx->tID = tID;
> @@ -2905,26 +2904,23 @@ u8 blockack_session_start(unifi_priv_t *priv,
> return FALSE;
> }
>
> - ba_session_rx = kmalloc(sizeof(ba_session_rx_struct), GFP_KERNEL);
> + ba_session_rx = kzalloc(sizeof(ba_session_rx_struct), GFP_KERNEL);
> if (!ba_session_rx) {
> unifi_error(priv, "%s: kmalloc failed for ba_session_rx\n", __FUNCTION__);
> return FALSE;
> }
> - memset(ba_session_rx, 0, sizeof(ba_session_rx_struct));
>
> ba_session_rx->wind_size = wind_size;
> ba_session_rx->start_sn = ba_session_rx->expected_sn = start_sn;
> ba_session_rx->trigger_ba_after_ssn = FALSE;
>
> - ba_session_rx->buffer = kmalloc(ba_session_rx->wind_size*sizeof(frame_desc_struct), GFP_KERNEL);
> + ba_session_rx->buffer = kzalloc(ba_session_rx->wind_size*sizeof(frame_desc_struct), GFP_KERNEL);
> if (!ba_session_rx->buffer) {
> kfree(ba_session_rx);
> unifi_error(priv, "%s: kmalloc failed for buffer\n", __FUNCTION__);
> return FALSE;
> }
>
> - memset(ba_session_rx->buffer, 0, ba_session_rx->wind_size*sizeof(frame_desc_struct));
> -
> INIT_WORK(&ba_session_rx->send_ba_err_task, uf_send_ba_err_wq);
> if (timeout) {
> ba_session_rx->timeout = timeout;
> --
> 1.7.9.5
>
Acked-by: Marcos Paulo de Souza <marcos.souza.org@xxxxxxxxx>
--
Att,
Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
