Re: [patch] staging: ozwpan: fix memcmp() test in oz_set_active_pd()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19/08/12 13:37, Tomas Winkler wrote:
On 18/08/12 09:47, Dan Carpenter wrote:
"addr" is a pointer so it's either 4 or 8 bytes, but actually we want
to compare 6 bytes (ETH_ALEN).

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Acked-by: Rupesh Gujare<rgujare@xxxxxxxxxxxxxxx>
why not to use 'if (is_zero_ether_addr())" from linux/etherdevice.h

Tom,

Thanks for pointing this out, that looks more efficient. Interested in submitting a patch ?

Dan,

What do you think ?


--
Regards,
Rupesh Gujare




_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux