Re: [PATCH 1/4] staging: csr: fix the coding style problems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 17, 2012 at 12:07 AM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Aug 16, 2012 at 03:56:59AM +0530, Devendra Naga wrote:
>> the following fixes:
>>
>> 1. replace spaces with tabs
>> 2. line over 80 characters
>
> Please only do one thing per patch, this does 2 things, and look, one of
> them was wrong, so I can't take it at all.
>
> Now if it was split into two pieces, then I could have taken the first
> one, and you could just redo the second.
>
> Care to redo this series based on the comments you got?
>
> thanks,
>
> greg k-h

Ok, so i am ignoring the line over 80 character warning and fixing the
rest, is it ok?

Thanks,
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux