A few changes to the amplc_pc236 driver. Patch 1 adds a couple of helper functions to check the bus type and hide the IS_ENABLED() stuff. Patch 2 changes pc236_detach to use the same bus type tests as pc236_attach(). Patch 3 (new in v2) changes the tests for whether to access the PCI-local bridge LCR registers to just check the bus type. Patch 4 defines a couple of macros to abbreviate the IS_ENABLED() macro calls. v2: Uses inline functions instead of functionlike macros, adds a new patch to use these functions in the tests whether to access the LCR registers, and changes the order of the patches so that the "abbreviate IS_ENABLED()" patch can be discarded if not wanted. 1: amplc_pc236: add helper functions to check bus type 2: amplc_pc236: check bus type in detach routine 3: amplc_pc236: check bus type before accessing LCR 4: amplc_pc236: abbreviate IS_ENABLED() drivers/staging/comedi/drivers/amplc_pc236.c | 64 ++++++++++++++++---------- 1 files changed, 40 insertions(+), 24 deletions(-) _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel