Re: [patch] Staging: xgifb: fix bitwise vs logical bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Dienstag, 14. August 2012, 09:04:45 schrieb Dan Carpenter:
> This is a static checker fix and not something I can test.  The intent
> of the code here is to set some bit flags.  For a logical OR the ">> 1"
> shift wouldn't make a difference.  So it should be using a bitwise OR.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
I guess this is correct.

Reviewed-by: Peter Huewe <peterhuewe@xxxxxx>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux