Re: [PATCH 1/5] staging/csr: clean coding style in uf_start_thread

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This was sent encoded as base64 which is awkward.

On Sat, Aug 04, 2012 at 01:01:38PM +0545, Devendra Naga wrote:
> -    } else {
> -        priv->bh_thread.prio = DEFAULT_PRIO;
> -    }
> +	} else
> +		priv->bh_thread.prio = DEFAULT_PRIO;

Probably it's not worth resending if this is the only complaint, but
actually the original had that braces correct.  If either side of
the if else statement gets uses curly braces then both sides should
use them.

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux