> -----Original Message----- > From: Olaf Hering [mailto:olaf@xxxxxxxxx] > Sent: Tuesday, July 24, 2012 12:54 PM > To: Stephen Hemminger > Cc: KY Srinivasan; gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devel@xxxxxxxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxx; apw@xxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; ben@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 10/17] Tools: hv: Gather ipv[4,6] gateway information > > On Tue, Jul 24, Stephen Hemminger wrote: > > > On Tue, 24 Jul 2012 09:01:34 -0700 > > "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx> wrote: > > > > > + memset(cmd, 0, sizeof(cmd)); > > > + strcat(cmd, "/sbin/ip -f inet route | grep -w "); > > > + strcat(cmd, if_name); > > > + strcat(cmd, " | awk '/default/ {print $3 }'"); > > > > > > Much simpler method: > > > > ip route show match 0/0 > > This also has the benefit that ip is not called with absolute path, now > that distros move binaries around. I could have chosen to not specify the full path for the ip command and for that matter all the external scripts I invoke from the KVP daemon. Do you mind if I submitted a patch to get rid of the absolute paths in this code. Stephen's suggestion is clearly simpler (I don't need to invoke awk to filter what we want). Steve, I could make this change as well as an additional patch. Regards, K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
