Re: [PATCH NEXT]staging "tidspbridge" Fix typos.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/23/2012 01:44 PM, Ramirez Luna, Omar wrote:
Hi Justin,

On Mon, Jul 23, 2012 at 8:49 AM, Justin P. Mattock
<justinmattock@xxxxxxxxx> wrote:
diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c b/drivers/staging/tidspbridge/core/tiomap3430.c
index f9609ce..2c82d5a 100644
--- a/drivers/staging/tidspbridge/core/tiomap3430.c
+++ b/drivers/staging/tidspbridge/core/tiomap3430.c
@@ -328,7 +328,7 @@ static int bridge_brd_read(struct bridge_dev_context *dev_ctxt,
                                            ul_num_bytes, mem_type);
                 return status;
         }
-       /* copy the data from  DSP memory, */
+       /* copy the data from DSP memory, */

I guess we can get rid of the comma (,) at the end of this sentence.

good catch!


...
diff --git a/drivers/staging/tidspbridge/include/dspbridge/proc.h b/drivers/staging/tidspbridge/include/dspbridge/proc.h
index a82380e..9cd5022 100644
--- a/drivers/staging/tidspbridge/include/dspbridge/proc.h
+++ b/drivers/staging/tidspbridge/include/dspbridge/proc.h
@@ -263,7 +263,7 @@ extern int proc_get_processor_id(void *proc, u32 * proc_id);
   *  Returns:
   *      0     :   Success.
   *      -EFAULT :   Invalid processor handle.
- *      -EPERM   :   General failure while retireving processor trace
+ *      -EPERM   :   General failure while retireing processor trace

This was meant to be 'retrieving'.

And given that this is focused on tidspbridge, could you change the
patch subject? To: staging: tidspbridge: fix typos.

Cheers,

Omar


ah.. I see now.. comments can be tough to decipher sometimes with what the writer is saying, helps to know what the code is doing.

cheers, resending the revised version, and Thank you for taking the time.

Justin P. Mattock
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux