Hello H Hartley Sweeten,
This is a semi-automatic email about new static checker warnings.
The patch e74f209ca995: "staging: comedi: cb_pcidas: remove forward
declarations 1" from Jun 26, 2012, leads to the following Smatch
complaint:
drivers/staging/comedi/drivers/cb_pcidas.c:1720 cb_pcidas_detach()
error: we previously assumed 'devpriv' could be null (see line 1709)
drivers/staging/comedi/drivers/cb_pcidas.c
1708
1709 if (devpriv) {
^^^^^^^
Old check.
1710 if (devpriv->s5933_config) {
1711 outl(INTCSR_INBOX_INTR_STATUS,
1712 devpriv->s5933_config + AMCC_OP_REG_INTCSR);
1713 }
1714 }
1715 if (dev->irq)
1716 free_irq(dev->irq, dev);
1717 if (dev->subdevices)
1718 subdev_8255_cleanup(dev, dev->subdevices + 2);
1719 if (pcidev) {
^^^^^^
This used to check "devpriv" but now it check "pcidev".
1720 if (devpriv->s5933_config)
1721 comedi_pci_disable(pcidev);
1722 pci_dev_put(pcidev);
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
