On Tue, Jul 17, 2012 at 11:37:07AM -0700, Anton Vorontsov wrote: > Headers should really include all the needed prototypes, types, defines > etc. to be self-contained. This is a long-standing issue, but apparently > the new tracing code unearthed it (SMP=n is also a prerequisite): > > In file included from fs/pstore/internal.h:4:0, > from fs/pstore/ftrace.c:21: > include/linux/pstore.h:43:15: error: field ‘read_mutex’ has incomplete type > > While at it, I also added the following: > > linux/types.h -> size_t, phys_addr_t, uXX and friends > linux/spinlock.h -> spinlock_t > linux/errno.h -> Exxxx > linux/time.h -> struct timespec (struct passed by value) > struct module and rs_control forward declaration (passed via pointers). > > Signed-off-by: Anton Vorontsov <anton.vorontsov@xxxxxxxxxx> > --- > > On Tue, Jul 17, 2012 at 11:19:44AM -0700, Greg Kroah-Hartman wrote: > > On Tue, Jul 17, 2012 at 11:13:59AM -0700, Anton Vorontsov wrote: > > > Headers should really include all the needed prototypes, types, defines > > > > <snip> > > > > Content-Transfer-Encoding: base64 > > > > That's not a nice way to send patches out, care to fix this and resend? > > I used 'git send-email' as normal, and it said: > > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > > OK, I checked what vger.kernel.org received, and it still says: > > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > And I see the email readable in the text editor. > > OK, with linux_banner I got what the problem is, but where base64 > came from?.. :-/ It looks like the devel mailing list does this conversion, ugh, mailman sucks at times. Sorry about that, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
