Hello, On Thu, Jul 12, 2012 at 6:34 PM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Jul 12, 2012 at 05:45:52AM +0300, Valentin, Eduardo wrote: >> Hello, >> >> On Thu, Jul 12, 2012 at 3:32 AM, Greg Kroah-Hartman >> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: >> > On Wed, Jul 11, 2012 at 11:41:06PM +0300, Eduardo Valentin wrote: >> >> In the System Control Module, OMAP supplies a voltage reference >> >> and a temperature sensor feature that are gathered in the band >> >> gap voltage and temperature sensor (VBGAPTS) module. The band >> >> gap provides current and voltage reference for its internal >> >> circuits and other analog IP blocks. The analog-to-digital >> >> converter (ADC) produces an output value that is proportional >> >> to the silicon temperature. >> >> >> >> This patch provides a platform driver which expose this feature. >> >> It is moduled as a MFD child of the System Control Module core >> >> MFD driver. >> >> >> >> This driver provides only APIs to access the device properties, >> >> like temperature, thresholds and update rate. >> >> >> >> Signed-off-by: Eduardo Valentin <eduardo.valentin@xxxxxx> >> >> Signed-off-by: J Keerthy <j-keerthy@xxxxxx> >> > >> > This patch gives me the following build error: >> > >> > rivers/staging/omap-thermal/omap-bandgap.c: In function ‘omap_bandgap_build’: >> > drivers/staging/omap-thermal/omap-bandgap.c:805:2: error: implicit declaration of function ‘of_match_device’ [-Werror=implicit-function-declaration] >> > drivers/staging/omap-thermal/omap-bandgap.c:805:8: warning: assignment makes pointer from integer without a cast [enabled by default] >> >> OK. Those I didn't see while testing on my side. I didn't use >> -Werror=implicit-function-declaration though. > > You shouldn't need to do that, just build this driver on your desktop > and you will see the error (hint, do you really want to build this on > x86-64 platforms?) Yeah, we shouldnt allow it. I will limit its compilation to omap only on v4. > > thanks, > > greg k-h -- Eduardo Valentin _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
