On Thu, Jul 12, 2012 at 11:54:28AM +0545, Devendra Naga wrote: > TCB has kcalloc' ed so no need to call memset again on it. > Gar... What about when this is called from et131x_adjust_link() and et1310_disable_phy_coma()? Really this changelog is annoying. Based on the changelog I was expecting the kcalloc() to be in the same function but it wasn't. So then I have to redo all your work and check every code path. You could have said what the code paths were in your description so I don't have to grovel through it all myself. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel