These variables are set during the attach of the device but they are never read. Just remove them. Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> Cc: Ian Abbott <abbotti@xxxxxxxxx> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/staging/comedi/drivers/dyna_pci10xx.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c index 16ad05f..32fcaee 100644 --- a/drivers/staging/comedi/drivers/dyna_pci10xx.c +++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c @@ -102,11 +102,10 @@ static const struct boardtype boardtypes[] = { }; struct dyna_pci10xx_private { - char valid; /* card is usable */ struct mutex mutex; /* device base address registers */ - unsigned long BADR0, BADR1, BADR2, BADR3, BADR4, BADR5; + unsigned long BADR2, BADR3; }; #define thisboard ((const struct boardtype *)dev->board_ptr) @@ -290,12 +289,8 @@ static int dyna_pci10xx_attach(struct comedi_device *dev, mutex_init(&devpriv->mutex); /* initialize device base address registers */ - devpriv->BADR0 = pci_resource_start(dev->pcidev, 0); - devpriv->BADR1 = pci_resource_start(dev->pcidev, 1); devpriv->BADR2 = pci_resource_start(dev->pcidev, 2); devpriv->BADR3 = pci_resource_start(dev->pcidev, 3); - devpriv->BADR4 = pci_resource_start(dev->pcidev, 4); - devpriv->BADR5 = pci_resource_start(dev->pcidev, 5); ret = comedi_alloc_subdevices(dev, 4); if (ret) { @@ -344,7 +339,6 @@ static int dyna_pci10xx_attach(struct comedi_device *dev, s->state = 0; s->insn_bits = dyna_pci10xx_do_insn_bits; - devpriv->valid = 1; mutex_unlock(&start_stop_sem); printk(KERN_INFO "comedi: dyna_pci10xx: %s - device setup completed!\n", -- 1.7.11 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel