Greg, On Wed, Jul 11, 2012 at 3:52 PM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Wed, Jul 11, 2012 at 01:07:17PM +0300, Valentin, Eduardo wrote: >> Hello Greg, >> >> On Mon, Jul 9, 2012 at 11:33 PM, Valentin, Eduardo >> <eduardo.valentin@xxxxxx> wrote: >> > Hello Greg, >> > >> > On Mon, Jul 9, 2012 at 10:31 PM, Greg Kroah-Hartman >> > g<gregkh@xxxxxxxxxxxxxxxxxxx> wrote: >> >> On Sat, Jul 07, 2012 at 10:57:49AM +0300, Eduardo Valentin wrote: >> >>> In the System Control Module, OMAP supplies a voltage reference >> >>> and a temperature sensor feature that are gathered in the band >> >>> gap voltage and temperature sensor (VBGAPTS) module. The band >> >>> gap provides current and voltage reference for its internal >> >>> circuits and other analog IP blocks. The analog-to-digital >> >>> converter (ADC) produces an output value that is proportional >> >>> to the silicon temperature. >> >>> >> >>> This patch provides a platform driver which expose this feature. >> >>> It is moduled as a MFD child of the System Control Module core >> >>> MFD driver. >> >>> >> >>> This driver provides only APIs to access the device properties, >> >>> like temperature, thresholds and update rate. >> >>> >> >>> Signed-off-by: Eduardo Valentin <eduardo.valentin@xxxxxx> >> >>> Signed-off-by: Keerthy <j-keerthy@xxxxxx> >> >> >> >> As much as I enjoy interesting names, odds are, "Keerthy" is not the >> >> real name of this person, right? In fact, based on the copyright >> >> comments in the code, I can almost guarantee it... >> >> >> >> I need a full-name please, no aliases or fake names allowed in kernel >> >> signed-off-by lines. >> >> >> >> Please resend these with that fixed up. >> > >> > Actually, his name is in fact Keerthy J. I can resend with the >> > additional "J" the way it is in the copyrights. >> >> While looking into his commits, I believe the SOB in this patch is one >> of the ways he uses to sign: >> commit f99c1d4f94f91fd3a20bd2eaa3be9c5e7d2668eb >> Author: Keerthy <j-keerthy@xxxxxx> >> Date: Tue Mar 1 19:12:26 2011 +0530 >> >> mfd: Add twl4030 madc driver >> >> Introducing a driver for MADC on TWL4030 powerIC. MADC stands for monitoring >> ADC. This driver monitors the real time conversion of analog signals like >> battery temperature, battery cuurent etc. >> >> Signed-off-by: Keerthy <j-keerthy@xxxxxx> >> Signed-off-by: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> >> >> So, I'd prefer to keep the way it is. > > But it doesn't match the copyright notice, which I am guessing TI got > "right" from a legal perspective, and as such, we need to also. > Now I see your point, it makes sense. Resending V3 of this patch in reply on this thread. It will contain his SOB the way it is in the copyright notice. > thanks, > > greg k-h -- Eduardo Valentin _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel