On Wed, Jul 11, 2012 at 12:13 AM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: >> I haven't see this? Why don't you want to disable a device at remove >> time? Because we put the disable in the generic pci layer? > > For some reason, I thought we didn't do this because of other > "interfaces" on the same card might then be shut down. But I must have > been thinking of something else, as lots of drivers do this, so adding > it here looks to be correct. > > So, sorry Devendra, you were right, care to resend this so I can apply > it? > Hi Greg, I will send the patch out in few hrs, with V2 name. Actually i was referring to the discussion here in this link, https://lkml.org/lkml/2005/2/13/82 it says about if the request regions fails we do not disable the device, as the other driver may be using the device. since the remove function of the driver is calling, which means that probe succeeded, so i think its fine to call pci_disable_device at driver_remove. > thanks, > > greg k-h Thanks, devendra. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
