On Fri, Jul 06, 2012 at 12:40:38PM +0200, Miguel Gómez wrote: > The piece of code that checks for LCDA in xgifb_probe() just checks for some > register values but doesn't really do anything in response to them (the actions > that should be executed are commented). > As nothing is really being done, the code can be safely removed. Are you sure? Some devices (foolish ones that is) need registers read to work properly as that is part of their start-up logic. Yeah, it doesn't seem to make sense, but hardware designers usually have good reasons for doing this type of thing. Or at least they think they do :) So have you tested the device after this change and it all works properly? You do have this device, right? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
