Re: [PATCH 0/6] staging: vt6655: Cleanup in usage of macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2012-07-08 at 23:51 -0300, Marcos Paulo de Souza wrote:
> Hi kernel guys!
> 
> This patchset aims to clean all unused and commented macros.
> 
> For this challenge, forgotten-macros tool helped us.

Perhaps there may be false positives in your code.

Many times, macros like the below are used:

#define SUBSYSTEM_PREFIX_FOO	1
#define SUBSYSTEM_PREFIX_BAR	2
#define SUBSYSTEM_PREFIX_BAZ	3

#define USE_TYPE(type)	SUBSYSTEM_PREFIX_##type

It doesn't seem your code knows that style.

Also, the tool might be more flexible if it was
written using perl or python.


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux