On 06/07/12 09:21, Dan Carpenter wrote:
> Sparse complains that "arg" is not a __user pointer. The "argp" and
> "arg" variables are equivalent but argp is declared as a __user pointer.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index be198c0..4363ed5 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -471,7 +471,7 @@ static int vme_user_ioctl(struct inode *inode, struct file *file,
> case CONTROL_MINOR:
> switch (cmd) {
> case VME_IRQ_GEN:
> - copied = copy_from_user(&irq_req, (char *)arg,
> + copied = copy_from_user(&irq_req, argp,
> sizeof(struct vme_irq_id));
> if (copied != 0) {
> printk(KERN_WARNING "Partial copy from userspace\n");
>
Looks OK to me:
Acked-By: Martyn Welch <martyn.welch@xxxxxx>
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748 | Manchester, M2 3AB
E martyn.welch@xxxxxx | VAT:GB 927559189
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
