Hi!
On Thu, Jul 05, 2012 at 04:45:48PM +0200, Miguel Gómez wrote:
if (!htotal || !vtotal) {
- pr_debug("XGIfb: Invalid 'var' information\n");
+ pr_debug("Invalid 'var' information\n");
[...]
- pr_err("xgifb: invalid value for option: %s\n", fullopt);
+ pr_err("Invalid value for option: %s\n", fullopt);
[...]
- pr_info("xgifb: options: %s\n", options);
+ pr_info("Options: %s\n", options);
Can you really remove the driver prefix?
As the pr format is defined as
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
it will include the module name for free.
if (reg1 != 0xa1) { /*I/O error */
- dev_err(&pdev->dev, "I/O error!!!");
+ dev_err(&pdev->dev, "I/O error!!!\n");
Those exclamation marks are just redundant noise.
Written down for the next round ;)
- dev_err(&pdev->dev, "unable request memory size %x\n",
+ dev_err(&pdev->dev, "Unable request memory size %x\n",
[...]
- dev_err(&pdev->dev, "no supported video mode found\n");
+ dev_err(&pdev->dev, "No supported video mode found\n");
[...]
- dev_info(&pdev->dev, "added MTRR\n");
+ dev_info(&pdev->dev, "Added MTRR\n");
[...]
- dev_err(&pdev->dev, "video BIOS not available\n");
+ dev_err(&pdev->dev, "Video BIOS not available\n");
[...]
- dev_err(&pdev->dev, "video BIOS corrupted\n");
+ dev_err(&pdev->dev, "Video BIOS corrupted\n");
What is the improvement?
Capitalizing the first letter, just to keep coherency. It's not the most
important change in the world, but it's nice :)
Regards!
--
Miguel Gómez
Igalia - http://www.igalia.com
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
