On Mon, Jul 2, 2012 at 2:10 PM, Ian Abbott <abbotti@xxxxxxxxx> wrote: > On 2012-07-01 14:36, Devendra Naga wrote: >> >> if alloc_private fail, we wont' release the I/O region, >> which was request_region 'ed. >> >> release the allocated I/O region if alloc_private fails. >> >> Signed-off-by: Devendra Naga <devendra.aaru@xxxxxxxxx> >> --- > > > No. The I/O region will be deallocated in fl512_detach() because > dev->iobase has been set non-zero. fl512_detach() will be called by the > comedi core if fl512_attach() returns an error. This is an unusual aspect > of the comedi drivers. > Oh, i didn't see the comedi core, i went and saw that its not freed up, so actaully driver unload wont' be called if driver attach , probe fail. so i started sending this patch. Sorry. > -- > -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- > -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- Devendra. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
