Re: [PATCH 4/7] tracing/function: Introduce persistent trace option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2012-06-26 at 16:23 -0700, Anton Vorontsov wrote:
>  
> @@ -219,6 +232,8 @@ static int func_set_flag(u32 old_flags, u32 bit, int set)
>  
>  		return 0;
>  	}
> +	if (bit == TRACE_FUNC_OPT_PSTORE)
> +		return 0;

Perhaps this should be a switch() statement, or at least put a
 } else if () {

As it can't be bit == TRACE_FUNC_OPT_STACK and bit ==
TRACE_FUNC_OPT_PSTORE.

-- Steve

>  
>  	return -EINVAL;
>  }


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux