On Mon, Jun 25, 2012 at 10:30:08AM -0700, Joe Perches wrote: > On Mon, 2012-06-25 at 10:24 -0700, Greg KH wrote: > > On Mon, Jun 25, 2012 at 10:20:00AM -0700, Joe Perches wrote: > > > Your patch-bot needs work. > > > > > > Converting printks to pr_<level> is trivial > > > and should be done all at once, not piecemeal. > > > > I'm not disagreeing with that, unfortunately this patch also did more > > than just pr_<level> conversions, which is why my patch-bot kicked in. > > > > So your patch-bot complaint generator needs work :) > > Or not. I think wholesale whitespace changes are just > fine too. That's nice, but you aren't the one accepting these patches, sorry. Also, again, I don't want to see whitespace changes at the same time as other changes like this, as it makes things harder to review. > git diff -w can ignore all those things pretty easily. Ok, but you can't "ignore" those changes before you apply them, which is what I have to do in reviewing patches. > Using a bot is certainly sensible and sanity-preserving. > I think it just needs a little tweaking. Again, the bot worked properly here, there was more than one logical change in the patch, so it needs to be split up. One for the pr_<level> chanegs, and one for the "lines greater than 80 columns" changes. If the bot annoys you so much, you can filter it away, or, if others complain, I can have it not post to mailing lists and only respond to the original author, but that's generally rude for having a conversation. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
