On Sun, Jun 24, 2012 at 09:45:58PM +0200, Jesper Juhl wrote: > Clean up the files iwctl.c and iwctl.h to match the official > CodingStyle a bit more closely. > > This is *not* a complete cleanup, but it brings the files quite close > to the accepted style compared to the state they were originally in > (which was a complete mess IMHO). > > It's mostly just whitespace changes, but there are also a few > pointless casts that were removed, a few tiny reshuffelings of code to > reduce indentation etc, but nothing major. There are no functional > changes. > > I could have split this in multiple patches, I guess, but then I'd > probably have ended up with a bunch of patches all touching the same > lines multiple times in order to make multiple different changes and > that didn't seem worth it. I opted to just do the whole thing in one > big patch, then we at least have a sane base upon which to apply > future smaller cleanups. Nope. It is worth it. Broken out patches are a million times easier to review. It frustrates me that you would do things like this when you know the rules. Which part is difficult to understand? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
